From 41de438583db7eeb2248a156ecd73f7f774383d3 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 1 Feb 2026 19:36:31 +0000
Subject: [PATCH] Address code review feedback: improve comments for
 vm.max_map_count and nerd fonts

Co-authored-by: ragusa-it <196988693+ragusa-it@users.noreply.github.com>
---
 modules/common.nix | 6 +++---
 modules/gaming.nix | 5 ++++-
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/modules/common.nix b/modules/common.nix
index 9ce6b35..974d5a4 100644
--- a/modules/common.nix
+++ b/modules/common.nix
@@ -121,9 +121,9 @@
   # FONTS
   # --------------------------------------------------------------------------
   fonts.packages = with pkgs; [
-    # Nerd fonts - syntax changed in NixOS 25.05+
-    # Old syntax was: (nerdfonts.override { fonts = [ "JetBrainsMono" ]; })
-    # New syntax is individual packages:
+    # Nerd fonts - syntax changed in nixpkgs after 24.05
+    # If using older nixpkgs: (nerdfonts.override { fonts = [ "JetBrainsMono" ]; })
+    # Current nixpkgs-unstable uses individual packages:
     nerd-fonts.jetbrains-mono
     
     # Other fonts
diff --git a/modules/gaming.nix b/modules/gaming.nix
index 90fa093..8f1656e 100644
--- a/modules/gaming.nix
+++ b/modules/gaming.nix
@@ -85,7 +85,10 @@
   boot.kernel.sysctl = {
     # Reduce swappiness for gaming
     "vm.swappiness" = 10;
-    # Increase max map count (needed for some games)
+    # Increase max map count for games requiring many memory mappings.
+    # This value (2^31 - 6) is the maximum safe value for signed 32-bit integers.
+    # Games like Star Citizen, Hogwarts Legacy, and some Unity/Unreal titles
+    # may crash without this setting due to high mmap requirements.
     "vm.max_map_count" = 2147483642;
   };