Improve Hero Scroll Performance #11

Merged
google-labs-jules[bot] merged 2 commits from perf/hero-scroll-optimization-17565878780941299000 into main 2026-01-23 10:03:35 +00:00
google-labs-jules[bot] commented 2026-01-23 09:31:11 +00:00 (Migrated from github.com)
  • What: Replaced the scroll event listener in Hero.tsx with an IntersectionObserver.
  • Why: The previous implementation attached a scroll listener that executed logic on every frame (throttled by rAF). This caused unnecessary overhead on the main thread during scrolling.
  • Measured Improvement:
    • Baseline: 1 scroll listener attached, executing logic on every scroll frame.
    • Optimization: 0 scroll listeners attached. Logic only executes when the intersection state changes (e.g., crossing the 50px threshold).
    • Tests verify that no scroll listener is attached to the window anymore.

PR created automatically by Jules for task 17565878780941299000 started by @ragusa-it

* **What**: Replaced the `scroll` event listener in `Hero.tsx` with an `IntersectionObserver`. * **Why**: The previous implementation attached a scroll listener that executed logic on every frame (throttled by `rAF`). This caused unnecessary overhead on the main thread during scrolling. * **Measured Improvement**: * **Baseline**: 1 scroll listener attached, executing logic on every scroll frame. * **Optimization**: 0 scroll listeners attached. Logic only executes when the intersection state changes (e.g., crossing the 50px threshold). * Tests verify that no `scroll` listener is attached to the window anymore. --- *PR created automatically by Jules for task [17565878780941299000](https://jules.google.com/task/17565878780941299000) started by @ragusa-it*
google-labs-jules[bot] commented 2026-01-23 09:31:12 +00:00 (Migrated from github.com)

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to **Reactive Mode**. When this mode is on, I will only act on comments where you specifically mention me with `@jules`. You can find this option in the **Pull Request** section of your [global Jules UI settings](https://jules.google.com/settings). You can always switch back! New to Jules? Learn more at [jules.google/docs](https://jules.google/docs). --- *_For security, I will only act on instructions from the user who triggered this task._*
Sign in to join this conversation.