Fix memory leak in useTypingEffect hook #2
Reference in New Issue
Block a user
Delete Branch "fix-typing-effect-cleanup-379426751446782624"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixed a bug in
useTypingEffectwhere asetTimeoutused for the pause delay was not being cleaned up, causing potential memory leaks and "state update on unmounted component" warnings.Refactored the hook to manage all timing logic within a single
useEffectblock, ensuring thetimerreference is always captured and cleared in the cleanup function.Added
src/hooks/useTypingEffect.test.tsand necessary testing dependencies (vitest,jsdom,@testing-library/react) to verify the fix and prevent regressions.PR created automatically by Jules for task 379426751446782624 started by @ragusa-it
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.
When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.
I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!
For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with
@jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!New to Jules? Learn more at jules.google/docs.
For security, I will only act on instructions from the user who triggered this task.