Fix GradientBlinds scroll drift on mobile #37
Reference in New Issue
Block a user
Delete Branch "fix/gradient-blinds-mobile-scroll-5721743487777744153"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Modified GradientBlinds effect to be static relative to container on mobile devices (<=768px). This prevents the "ghost drift" effect where the spotlight position shifts during inertia scrolling because the animation loop was updating the target based on scroll offset.
On desktop, the existing behavior (tracking mouse with scroll compensation) is preserved. On mobile, the spotlight updates only on touch/drag events and remains fixed relative to the container during scrolling.
PR created automatically by Jules for task 5721743487777744153 started by @ragusa-it
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.
When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.
I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!
For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with
@jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!New to Jules? Learn more at jules.google/docs.
For security, I will only act on instructions from the user who triggered this task.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:
7bc42f8d48ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When
isMobileRefis true,onPointerMovenow clearspointerPosRef. In the render loop, the no‑dampening path (mouseDampening <= 0) only appliesmouseTargetRefifpointerPosRefis non‑null, so on mobile the spotlight never updates for users who setmouseDampeningto 0. This is a regression from the previous behavior (touch/mouse would still move the spotlight) and will affect any consumer disabling dampening.Useful? React with 👍 / 👎.