From 6041adcaf30a4cf0a618e846b09681c217a1f92e Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Mon, 2 Feb 2026 01:47:55 +0000 Subject: [PATCH] feat(a11y): add skip to content link - Add `SkipLink` component to `src/components/ui` - Integrate `SkipLink` in `src/App.tsx` - Add `id="main-content"` and proper focus management to page containers - Add translations for the skip link text - Add unit test for `SkipLink` Co-authored-by: ragusa-it <196988693+ragusa-it@users.noreply.github.com> --- .Jules/palette.md | 4 +++ src/App.tsx | 3 ++- src/components/ui/SkipLink.module.css | 20 +++++++++++++++ src/components/ui/SkipLink.tsx | 12 +++++++++ src/components/ui/__tests__/SkipLink.test.tsx | 25 +++++++++++++++++++ src/components/ui/index.ts | 1 + src/i18n/de.ts | 1 + src/i18n/en.ts | 1 + src/pages/About.tsx | 8 +++++- src/pages/Contact.tsx | 7 +++++- src/pages/Home.tsx | 2 +- 11 files changed, 80 insertions(+), 4 deletions(-) create mode 100644 src/components/ui/SkipLink.module.css create mode 100644 src/components/ui/SkipLink.tsx create mode 100644 src/components/ui/__tests__/SkipLink.test.tsx diff --git a/.Jules/palette.md b/.Jules/palette.md index 7d3d798..6021891 100644 --- a/.Jules/palette.md +++ b/.Jules/palette.md @@ -9,3 +9,7 @@ ## 2024-05-24 - Enhancing Inputs Safely **Learning:** Adding features like character counters to generic input components must handle both controlled and uncontrolled states. Assuming a component is controlled (using `props.value`) can break uncontrolled usage by showing stale data (e.g., sticking at 0/100). **Action:** When enhancing generic components, detect uncontrolled state (e.g., `props.value === undefined`) and either implement internal state tracking or gracefully degrade (hide the feature) to avoid misleading UX. + +## 2025-02-14 - Skip to Content Implementation +**Learning:** Implementing a "Skip to Content" link requires not just the link component, but ensuring the target `
` element has `tabIndex={-1}` and `outline: 'none'` (or CSS equivalent) to ensure programmatic focus works correctly without creating an ugly focus ring on the container. +**Action:** When adding skip links, always verify the target container's focusability and visual focus style. diff --git a/src/App.tsx b/src/App.tsx index 5c4e796..41f5efc 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -3,7 +3,7 @@ import { BrowserRouter, Routes, Route } from 'react-router-dom'; import { LanguageProvider } from './i18n'; import { Navbar, Footer, FancyCursor, ScrollToTop } from './components/layout'; import { Home } from './pages/Home'; -import { PageLoader } from './components/ui'; +import { PageLoader, SkipLink } from './components/ui'; import './styles/global.css'; // Lazy load pages to reduce initial bundle size. @@ -15,6 +15,7 @@ export function App() { return ( + diff --git a/src/components/ui/SkipLink.module.css b/src/components/ui/SkipLink.module.css new file mode 100644 index 0000000..dcd2567 --- /dev/null +++ b/src/components/ui/SkipLink.module.css @@ -0,0 +1,20 @@ +.skipLink { + position: absolute; + top: 1rem; + left: 1rem; + padding: 0.75rem 1.25rem; + background: var(--md-sys-color-primary); + color: var(--md-sys-color-on-primary); + font-weight: 500; + text-decoration: none; + border-radius: 0.5rem; + z-index: 1000; + transform: translateY(-200%); + transition: transform 0.2s cubic-bezier(0.4, 0, 0.2, 1); + outline: none; +} + +.skipLink:focus { + transform: translateY(0); + box-shadow: 0 4px 6px -1px rgba(0, 0, 0, 0.1), 0 2px 4px -1px rgba(0, 0, 0, 0.06); +} diff --git a/src/components/ui/SkipLink.tsx b/src/components/ui/SkipLink.tsx new file mode 100644 index 0000000..7e1dcdc --- /dev/null +++ b/src/components/ui/SkipLink.tsx @@ -0,0 +1,12 @@ +import { useTranslation } from '../../i18n'; +import styles from './SkipLink.module.css'; + +export function SkipLink() { + const { t } = useTranslation(); + + return ( + + {t.nav.skipToContent} + + ); +} diff --git a/src/components/ui/__tests__/SkipLink.test.tsx b/src/components/ui/__tests__/SkipLink.test.tsx new file mode 100644 index 0000000..f115321 --- /dev/null +++ b/src/components/ui/__tests__/SkipLink.test.tsx @@ -0,0 +1,25 @@ +// @vitest-environment jsdom +import { render, screen, cleanup } from '@testing-library/react'; +import { describe, it, expect, afterEach, vi } from 'vitest'; +import { SkipLink } from '../SkipLink'; + +vi.mock('../../../i18n', () => ({ + useTranslation: () => ({ + t: { + nav: { + skipToContent: 'Skip to content', + }, + }, + }), +})); + +describe('SkipLink', () => { + afterEach(() => cleanup()); + + it('renders with correct href and text', () => { + render(); + const link = screen.getByRole('link', { name: /skip to content/i }); + expect(link).toBeTruthy(); + expect(link.getAttribute('href')).toBe('#main-content'); + }); +}); diff --git a/src/components/ui/index.ts b/src/components/ui/index.ts index 78cc7f9..f857f96 100644 --- a/src/components/ui/index.ts +++ b/src/components/ui/index.ts @@ -2,3 +2,4 @@ export { Button } from './Button'; export { Card } from './Card'; export { Input, Textarea } from './Input'; export { PageLoader } from './PageLoader'; +export { SkipLink } from './SkipLink'; diff --git a/src/i18n/de.ts b/src/i18n/de.ts index 0b42d51..1c8d329 100644 --- a/src/i18n/de.ts +++ b/src/i18n/de.ts @@ -1,6 +1,7 @@ export const de = { // Navigation nav: { + skipToContent: 'Zum Inhalt springen', home: 'Startseite', about: 'Über uns', contact: 'Kontakt', diff --git a/src/i18n/en.ts b/src/i18n/en.ts index 20c8a34..57c2370 100644 --- a/src/i18n/en.ts +++ b/src/i18n/en.ts @@ -3,6 +3,7 @@ import type { Translations } from './de'; export const en: Translations = { // Navigation nav: { + skipToContent: 'Skip to content', home: 'Home', about: 'About', contact: 'Contact', diff --git a/src/pages/About.tsx b/src/pages/About.tsx index 928e421..07b09a7 100644 --- a/src/pages/About.tsx +++ b/src/pages/About.tsx @@ -46,7 +46,13 @@ export function About() { const location = useLocation(); return ( -
+
{/* Hero Section */}
diff --git a/src/pages/Contact.tsx b/src/pages/Contact.tsx index 6332455..adb4d20 100644 --- a/src/pages/Contact.tsx +++ b/src/pages/Contact.tsx @@ -133,7 +133,12 @@ export function Contact() { }; return ( -
+
{/* Hero */}
diff --git a/src/pages/Home.tsx b/src/pages/Home.tsx index 9273d84..685f6fd 100644 --- a/src/pages/Home.tsx +++ b/src/pages/Home.tsx @@ -2,7 +2,7 @@ import { Hero, Services } from '../components/sections'; export function Home() { return ( -
+
-- 2.49.1