Merge pull request #33 from ragusa-it/palette-contact-a11y-2847648259567731202

🎨 Palette: Improve Contact form accessibility

.jules/palette.md

@@ -1,3 +1,6 @@
+## 2025-02-18 - Missing Alerts for Dynamic Status
+**Learning:** The application uses `framer-motion` for dynamic feedback messages but consistently lacks `role="alert"` and `aria-live` attributes, causing screen readers to miss critical status updates.
+**Action:** When auditing forms, check all `motion.div/p` elements used for feedback and add `role="alert"` and `aria-live="polite"` (or "assertive" for errors).
 ## 2024-05-22 - Semantic Required Fields with Custom Validation
 **Learning:** To combine custom validation UI with semantic `required` attributes (vital for a11y), add `noValidate` to the `<form>`. This prevents native browser bubbles while keeping the accessibility benefits.
 **Action:** Use `noValidate` on forms when implementing custom validation but keep `required` attributes on inputs.

src/pages/Contact.tsx

@@ -249,6 +249,8 @@ export function Contact() {
                     className={styles.error}
                     initial={{ opacity: 0, y: 10 }}
                     animate={{ opacity: 1, y: 0 }}
+                    role="alert"
+                    aria-live="polite"
                   >
                     {t.contact.form.rateLimit}
                   </motion.p>
@@ -273,6 +275,7 @@ export function Contact() {
                       fill="none"
                       stroke="currentColor"
                       strokeWidth="2"
+                      aria-hidden="true"
                     >
                       <path d="M4 4h16c1.1 0 2 .9 2 2v12c0 1.1-.9 2-2 2H4c-1.1 0-2-.9-2-2V6c0-1.1.9-2 2-2z" />
                       <polyline points="22,6 12,13 2,6" />
@@ -288,7 +291,7 @@ export function Contact() {
 
                 <div className={styles.infoItem}>
                   <div className={styles.infoIcon}>
-                    <svg viewBox="0 0 24 24" fill="currentColor">
+                    <svg viewBox="0 0 24 24" fill="currentColor" aria-hidden="true">
                       <path d="M12 0C5.37 0 0 5.37 0 12c0 5.31 3.435 9.795 8.205 11.385.6.105.825-.255.825-.57 0-.285-.015-1.23-.015-2.235-3.015.555-3.795-.735-4.035-1.41-.135-.345-.72-1.41-1.23-1.695-.42-.225-1.02-.78-.015-.795.945-.015 1.62.87 1.845 1.23 1.08 1.815 2.805 1.305 3.495.99.105-.78.42-1.305.765-1.605-2.67-.3-5.46-1.335-5.46-5.925 0-1.305.465-2.385 1.23-3.225-.12-.3-.54-1.53.12-3.18 0 0 1.005-.315 3.3 1.23.96-.27 1.98-.405 3-.405s2.04.135 3 .405c2.295-1.56 3.3-1.23 3.3-1.23.66 1.65.24 2.88.12 3.18.765.84 1.23 1.905 1.23 3.225 0 4.605-2.805 5.625-5.475 5.925.435.375.81 1.095.81 2.22 0 1.605-.015 2.895-.015 3.3 0 .315.225.69.825.57A12.02 12.02 0 0024 12c0-6.63-5.37-12-12-12z" />
                     </svg>
                   </div>

src/pages/__tests__/Contact.test.tsx

@@ -116,6 +116,8 @@ describe('Contact Page', () => {
     // Verify success message
     const successMessage = await screen.findByText('Message sent successfully!');
     expect(successMessage).toBeTruthy();
+    expect(successMessage.getAttribute('role')).toBe('alert');
+    expect(successMessage.getAttribute('aria-live')).toBe('polite');
   });
 
   it('sanitizes input before sending', async () => {
@@ -193,4 +195,32 @@ describe('Contact Page', () => {
     // EmailJS should NOT be called
     expect(emailjs.send).not.toHaveBeenCalled();
   });
+
+  it('shows error message with alert role when submission fails', async () => {
+    // Mock failure
+    const sendMock = vi.mocked(emailjs.send);
+    sendMock.mockRejectedValueOnce(new Error('Network error'));
+
+    render(<Contact />);
+
+    // Fill out the form
+    fireEvent.change(screen.getByLabelText('Name'), { target: { value: 'John Doe' } });
+    fireEvent.change(screen.getByLabelText('Email'), { target: { value: 'john@example.com' } });
+    fireEvent.change(screen.getByLabelText('Subject'), { target: { value: 'Test Subject' } });
+    fireEvent.change(screen.getByLabelText('Message'), { target: { value: 'Hello world' } });
+
+    // Submit
+    fireEvent.click(screen.getByRole('button', { name: 'Send Message' }));
+
+    // Wait for submission attempt
+    await waitFor(() => {
+      expect(emailjs.send).toHaveBeenCalled();
+    });
+
+    // Verify error message
+    const errorMessage = await screen.findByText('Failed to send message.');
+    expect(errorMessage).toBeTruthy();
+    expect(errorMessage.getAttribute('role')).toBe('alert');
+    expect(errorMessage.getAttribute('aria-live')).toBe('polite');
+  });
 });