Compare commits
1 Commits
bolt-optim
...
sentinel-s
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
5d9f78d64f |
@@ -27,3 +27,8 @@
|
||||
**Vulnerability:** Allowing users to register or submit forms with disposable email addresses (e.g., mailinator.com) can lead to spam, abuse, and polluted data.
|
||||
**Learning:** While true email verification requires a backend or API, a simple client-side blocklist of common disposable domains is a highly effective, low-cost first line of defense.
|
||||
**Prevention:** Maintain a list of known disposable domains (e.g., `BLOCKED_DOMAINS`) and check the domain part of the email address during validation.
|
||||
|
||||
## 2026-02-14 - Backtick Escaping in Sanitization
|
||||
**Vulnerability:** Standard HTML entity encoding often overlooks backticks (`` ` ``), which are dangerous in JavaScript template literals.
|
||||
**Learning:** While `&`, `<`, `>`, `"`, `'` are standard, backticks are unique to modern JS. If a sanitized string is interpolated into a JS template literal, an unescaped backtick can break out of the string context and allow arbitrary code execution.
|
||||
**Prevention:** Always include `.replace(/`/g, "`")` in custom HTML sanitization functions to prevent injection in JS contexts.
|
||||
|
||||
@@ -65,8 +65,7 @@ const GradientBlinds: React.FC<GradientBlindsProps> = ({
|
||||
const rendererRef = useRef<Renderer | null>(null);
|
||||
const mouseTargetRef = useRef<[number, number]>([0, 0]);
|
||||
// Optimization: store raw pointer position (viewport coords) to decouple event handling from calculation
|
||||
// Changed to a stable object to avoid GC pressure in high-frequency event handlers
|
||||
const pointerPosRef = useRef<{ x: number; y: number; active: boolean }>({ x: 0, y: 0, active: false });
|
||||
const pointerPosRef = useRef<{ x: number; y: number } | null>(null);
|
||||
const isMobileRef = useRef<boolean>(false);
|
||||
const lastTimeRef = useRef<number>(0);
|
||||
const firstResizeRef = useRef<boolean>(true);
|
||||
@@ -305,8 +304,7 @@ void main() {
|
||||
const cx = gl.drawingBufferWidth / 2;
|
||||
const cy = gl.drawingBufferHeight / 2;
|
||||
uniforms.iMouse.value = [cx, cy];
|
||||
mouseTargetRef.current[0] = cx;
|
||||
mouseTargetRef.current[1] = cy;
|
||||
mouseTargetRef.current = [cx, cy];
|
||||
}
|
||||
};
|
||||
|
||||
@@ -334,13 +332,10 @@ void main() {
|
||||
x = (e.clientX - rect.left) * scale;
|
||||
y = (rect.height - (e.clientY - rect.top)) * scale;
|
||||
}
|
||||
mouseTargetRef.current[0] = x;
|
||||
mouseTargetRef.current[1] = y;
|
||||
pointerPosRef.current.active = false; // Ensure loop doesn't override
|
||||
mouseTargetRef.current = [x, y];
|
||||
pointerPosRef.current = null; // Ensure loop doesn't override
|
||||
} else {
|
||||
pointerPosRef.current.x = e.clientX;
|
||||
pointerPosRef.current.y = e.clientY;
|
||||
pointerPosRef.current.active = true;
|
||||
pointerPosRef.current = { x: e.clientX, y: e.clientY };
|
||||
}
|
||||
};
|
||||
|
||||
@@ -349,7 +344,7 @@ void main() {
|
||||
uniforms.iTime.value = t * 0.001;
|
||||
|
||||
// Update target based on pointer position and scroll offset
|
||||
if (pointerPosRef.current.active) {
|
||||
if (pointerPosRef.current) {
|
||||
const scale = (renderer as unknown as { dpr?: number }).dpr || 1;
|
||||
let x, y;
|
||||
|
||||
@@ -366,8 +361,7 @@ void main() {
|
||||
x = (pointerPosRef.current.x - rect.left) * scale;
|
||||
y = (rect.height - (pointerPosRef.current.y - rect.top)) * scale;
|
||||
}
|
||||
mouseTargetRef.current[0] = x;
|
||||
mouseTargetRef.current[1] = y;
|
||||
mouseTargetRef.current = [x, y];
|
||||
}
|
||||
|
||||
if (mouseDampening > 0) {
|
||||
@@ -382,13 +376,8 @@ void main() {
|
||||
cur[0] += (target[0] - cur[0]) * factor;
|
||||
cur[1] += (target[1] - cur[1]) * factor;
|
||||
} else {
|
||||
if (pointerPosRef.current.active || isMobileRef.current) {
|
||||
// In no-dampening mode, update values directly.
|
||||
// We copy values instead of assigning the reference to avoid aliasing issues
|
||||
// (where cur and target become the same array) if dampening is enabled later
|
||||
// without re-creating uniforms (though currently effect deps handle that).
|
||||
uniforms.iMouse.value[0] = mouseTargetRef.current[0];
|
||||
uniforms.iMouse.value[1] = mouseTargetRef.current[1];
|
||||
if (pointerPosRef.current || isMobileRef.current) {
|
||||
uniforms.iMouse.value = mouseTargetRef.current;
|
||||
}
|
||||
lastTimeRef.current = t;
|
||||
}
|
||||
|
||||
@@ -25,6 +25,11 @@ describe('Security Utils', () => {
|
||||
const expected = '<script>alert("XSS")</script>';
|
||||
expect(sanitizeInput(input)).toBe(expected);
|
||||
});
|
||||
|
||||
it('escapes backticks', () => {
|
||||
expect(sanitizeInput('`')).toBe('`');
|
||||
expect(sanitizeInput('user`name')).toBe('user`name');
|
||||
});
|
||||
});
|
||||
|
||||
describe('isValidEmail', () => {
|
||||
|
||||
@@ -14,7 +14,8 @@ export function sanitizeInput(input: string): string {
|
||||
.replace(/</g, "<")
|
||||
.replace(/>/g, ">")
|
||||
.replace(/"/g, """)
|
||||
.replace(/'/g, "'");
|
||||
.replace(/'/g, "'")
|
||||
.replace(/`/g, "`");
|
||||
}
|
||||
|
||||
// Common disposable email providers and invalid domains
|
||||
|
||||
Reference in New Issue
Block a user