Palette: Enable accessibility attributes on Button component #21
Reference in New Issue
Block a user
Delete Branch "palette/button-a11y-fix-1082057340107931289"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
💡 What: Refactored the
Buttoncomponent to extendButtonHTMLAttributesand spread...propsto the underlying button element.🎯 Why: The previous implementation swallowed custom attributes, making it impossible to add
aria-label,aria-expanded, or other accessibility properties to buttons (especially icon-only buttons).📸 Before/After: No visual change, but the DOM now correctly reflects passed attributes.
♿ Accessibility: Enables full accessibility support for all buttons using this component.
Testing: Added
src/components/ui/__tests__/Button.test.tsxto verifyaria-labeland other props are passed correctly. Ran existing tests to ensure no regressions.PR created automatically by Jules for task 1082057340107931289 started by @ragusa-it
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.
When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.
I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!
For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with
@jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!New to Jules? Learn more at jules.google/docs.
For security, I will only act on instructions from the user who triggered this task.