🎨 Palette: Add Skip to Content Link #43

Open
ragusa-it wants to merge 1 commits from palette-ux-skip-link-4183261526673199462 into main
7 changed files with 80 additions and 9 deletions

View File

@@ -3,7 +3,7 @@ import { BrowserRouter, Routes, Route } from 'react-router-dom';
import { LanguageProvider } from './i18n';
import { Navbar, Footer, FancyCursor, ScrollToTop } from './components/layout';
import { Home } from './pages/Home';
import { PageLoader } from './components/ui';
import { PageLoader, SkipLink } from './components/ui';
import './styles/global.css';
// Lazy load pages to reduce initial bundle size.
@@ -15,17 +15,20 @@ export function App() {
return (
<LanguageProvider>
<BrowserRouter>
<SkipLink />
<ScrollToTop />
<FancyCursor />
<Navbar />
{/* Suspense handles the loading state for lazy-loaded routes */}
<Suspense fallback={<PageLoader />}>
<Routes>
<Route path="/" element={<Home />} />
<Route path="/about" element={<About />} />
<Route path="/contact" element={<Contact />} />
</Routes>
</Suspense>
<main id="main-content" tabIndex={-1} style={{ flex: 1, outline: 'none' }}>
{/* Suspense handles the loading state for lazy-loaded routes */}
<Suspense fallback={<PageLoader />}>
<Routes>
<Route path="/" element={<Home />} />
<Route path="/about" element={<About />} />
<Route path="/contact" element={<Contact />} />
</Routes>
</Suspense>
</main>
<Footer />
</BrowserRouter>
</LanguageProvider>

View File

@@ -0,0 +1,20 @@
.skipLink {
position: absolute;
top: 1rem;
left: 1rem;
z-index: 100;
padding: 0.75rem 1.25rem;
background-color: var(--md-sys-color-primary);
color: var(--md-sys-color-on-primary);
font-weight: 600;
border-radius: var(--radius-md);
text-decoration: none;
transform: translateY(-200%);
transition: transform var(--transition-normal);
outline: none;
box-shadow: var(--md-sys-color-shadow) 0px 4px 8px 3px;
}
.skipLink:focus {
transform: translateY(0);
}

View File

@@ -0,0 +1,12 @@
import { useTranslation } from '../../i18n';
import styles from './SkipLink.module.css';
export function SkipLink() {
const { t } = useTranslation();
return (
<a href="#main-content" className={styles.skipLink}>
{t.nav.skipLink}
</a>
);
}

View File

@@ -0,0 +1,33 @@
// @vitest-environment jsdom
import { render, screen, cleanup } from '@testing-library/react';
import { describe, it, expect, afterEach } from 'vitest';
import { SkipLink } from '../SkipLink';
import { LanguageProvider } from '../../../i18n';
describe('SkipLink', () => {
afterEach(() => {
cleanup();
});
const renderWithProviders = (component: React.ReactNode) => {
chatgpt-codex-connector[bot] commented 2026-01-31 02:09:28 +00:00 (Migrated from github.com)
Review

P2 Badge Import React types before using React.ReactNode

The test defines renderWithProviders with a React.ReactNode parameter but never imports React (or ReactNode). With the repo’s tsconfig.json using ES modules and no allowUmdGlobalAccess, React is not in the global namespace, so pnpm exec tsc --noEmit (and typechecking in vitest) will error with Cannot find namespace 'React'. Import type { ReactNode } from react (or import type * as React) and use that type to keep the file compiling.

Useful? React with 👍 / 👎.

**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Import React types before using React.ReactNode** The test defines `renderWithProviders` with a `React.ReactNode` parameter but never imports `React` (or `ReactNode`). With the repo’s `tsconfig.json` using ES modules and no `allowUmdGlobalAccess`, `React` is not in the global namespace, so `pnpm exec tsc --noEmit` (and typechecking in vitest) will error with `Cannot find namespace 'React'`. Import `type { ReactNode }` from `react` (or `import type * as React`) and use that type to keep the file compiling. Useful? React with 👍 / 👎.
return render(
<LanguageProvider>
{component}
</LanguageProvider>
);
};
it('renders correctly with correct href', () => {
renderWithProviders(<SkipLink />);
const link = screen.getByRole('link');
expect(link).toBeTruthy();
expect(link.getAttribute('href')).toBe('#main-content');
});
it('renders translated text', () => {
renderWithProviders(<SkipLink />);
const link = screen.getByRole('link');
const text = link.textContent;
expect(text === 'Zum Inhalt springen' || text === 'Skip to content').toBe(true);
});
});

View File

@@ -2,3 +2,4 @@ export { Button } from './Button';
export { Card } from './Card';
export { Input, Textarea } from './Input';
export { PageLoader } from './PageLoader';
export { SkipLink } from './SkipLink';

View File

@@ -1,6 +1,7 @@
export const de = {
// Navigation
nav: {
skipLink: 'Zum Inhalt springen',
home: 'Startseite',
about: 'Über uns',
contact: 'Kontakt',

View File

@@ -3,6 +3,7 @@ import type { Translations } from './de';
export const en: Translations = {
// Navigation
nav: {
skipLink: 'Skip to content',
home: 'Home',
about: 'About',
contact: 'Contact',