Refactor useTypingEffect to fix timer leak and optimize re-renders #5

Merged
google-labs-jules[bot] merged 1 commits from fix-typing-effect-timer-leak-7224626563395361239 into main 2026-01-23 09:06:33 +00:00
google-labs-jules[bot] commented 2026-01-22 08:22:42 +00:00 (Migrated from github.com)

Refactored useTypingEffect to use a single useEffect with a unified setTimeout logic, ensuring all timers are tracked and cleaned up properly. This addresses the reported timer leak issue.

Additionally, implemented a performance optimization by stabilizing the words dependency using useMemo and JSON.stringify. This prevents unnecessary effect re-runs and timer resets when the words array reference changes but its content remains identical (e.g., during parent re-renders), which previously caused stuttering or halted typing.

Verification:

  • Added a reproduction test case (since removed) to verify the fix for unstable words prop.
  • Verified that existing tests pass.
  • Code review confirmed the fix addresses the leak and improves performance.

PR created automatically by Jules for task 7224626563395361239 started by @ragusa-it

Refactored `useTypingEffect` to use a single `useEffect` with a unified `setTimeout` logic, ensuring all timers are tracked and cleaned up properly. This addresses the reported timer leak issue. Additionally, implemented a performance optimization by stabilizing the `words` dependency using `useMemo` and `JSON.stringify`. This prevents unnecessary effect re-runs and timer resets when the `words` array reference changes but its content remains identical (e.g., during parent re-renders), which previously caused stuttering or halted typing. Verification: - Added a reproduction test case (since removed) to verify the fix for unstable `words` prop. - Verified that existing tests pass. - Code review confirmed the fix addresses the leak and improves performance. --- *PR created automatically by Jules for task [7224626563395361239](https://jules.google.com/task/7224626563395361239) started by @ragusa-it*
google-labs-jules[bot] commented 2026-01-22 08:22:43 +00:00 (Migrated from github.com)

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to **Reactive Mode**. When this mode is on, I will only act on comments where you specifically mention me with `@jules`. You can find this option in the **Pull Request** section of your [global Jules UI settings](https://jules.google.com/settings). You can always switch back! New to Jules? Learn more at [jules.google/docs](https://jules.google/docs). --- *_For security, I will only act on instructions from the user who triggered this task._*
Sign in to join this conversation.