Compare commits
1 Commits
sentinel-s
...
bolt-optim
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d817d42174 |
@@ -27,8 +27,3 @@
|
|||||||
**Vulnerability:** Allowing users to register or submit forms with disposable email addresses (e.g., mailinator.com) can lead to spam, abuse, and polluted data.
|
**Vulnerability:** Allowing users to register or submit forms with disposable email addresses (e.g., mailinator.com) can lead to spam, abuse, and polluted data.
|
||||||
**Learning:** While true email verification requires a backend or API, a simple client-side blocklist of common disposable domains is a highly effective, low-cost first line of defense.
|
**Learning:** While true email verification requires a backend or API, a simple client-side blocklist of common disposable domains is a highly effective, low-cost first line of defense.
|
||||||
**Prevention:** Maintain a list of known disposable domains (e.g., `BLOCKED_DOMAINS`) and check the domain part of the email address during validation.
|
**Prevention:** Maintain a list of known disposable domains (e.g., `BLOCKED_DOMAINS`) and check the domain part of the email address during validation.
|
||||||
|
|
||||||
## 2026-02-14 - Backtick Escaping in Sanitization
|
|
||||||
**Vulnerability:** Standard HTML entity encoding often overlooks backticks (`` ` ``), which are dangerous in JavaScript template literals.
|
|
||||||
**Learning:** While `&`, `<`, `>`, `"`, `'` are standard, backticks are unique to modern JS. If a sanitized string is interpolated into a JS template literal, an unescaped backtick can break out of the string context and allow arbitrary code execution.
|
|
||||||
**Prevention:** Always include `.replace(/`/g, "`")` in custom HTML sanitization functions to prevent injection in JS contexts.
|
|
||||||
|
|||||||
@@ -65,7 +65,8 @@ const GradientBlinds: React.FC<GradientBlindsProps> = ({
|
|||||||
const rendererRef = useRef<Renderer | null>(null);
|
const rendererRef = useRef<Renderer | null>(null);
|
||||||
const mouseTargetRef = useRef<[number, number]>([0, 0]);
|
const mouseTargetRef = useRef<[number, number]>([0, 0]);
|
||||||
// Optimization: store raw pointer position (viewport coords) to decouple event handling from calculation
|
// Optimization: store raw pointer position (viewport coords) to decouple event handling from calculation
|
||||||
const pointerPosRef = useRef<{ x: number; y: number } | null>(null);
|
// Changed to a stable object to avoid GC pressure in high-frequency event handlers
|
||||||
|
const pointerPosRef = useRef<{ x: number; y: number; active: boolean }>({ x: 0, y: 0, active: false });
|
||||||
const isMobileRef = useRef<boolean>(false);
|
const isMobileRef = useRef<boolean>(false);
|
||||||
const lastTimeRef = useRef<number>(0);
|
const lastTimeRef = useRef<number>(0);
|
||||||
const firstResizeRef = useRef<boolean>(true);
|
const firstResizeRef = useRef<boolean>(true);
|
||||||
@@ -304,7 +305,8 @@ void main() {
|
|||||||
const cx = gl.drawingBufferWidth / 2;
|
const cx = gl.drawingBufferWidth / 2;
|
||||||
const cy = gl.drawingBufferHeight / 2;
|
const cy = gl.drawingBufferHeight / 2;
|
||||||
uniforms.iMouse.value = [cx, cy];
|
uniforms.iMouse.value = [cx, cy];
|
||||||
mouseTargetRef.current = [cx, cy];
|
mouseTargetRef.current[0] = cx;
|
||||||
|
mouseTargetRef.current[1] = cy;
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -332,10 +334,13 @@ void main() {
|
|||||||
x = (e.clientX - rect.left) * scale;
|
x = (e.clientX - rect.left) * scale;
|
||||||
y = (rect.height - (e.clientY - rect.top)) * scale;
|
y = (rect.height - (e.clientY - rect.top)) * scale;
|
||||||
}
|
}
|
||||||
mouseTargetRef.current = [x, y];
|
mouseTargetRef.current[0] = x;
|
||||||
pointerPosRef.current = null; // Ensure loop doesn't override
|
mouseTargetRef.current[1] = y;
|
||||||
|
pointerPosRef.current.active = false; // Ensure loop doesn't override
|
||||||
} else {
|
} else {
|
||||||
pointerPosRef.current = { x: e.clientX, y: e.clientY };
|
pointerPosRef.current.x = e.clientX;
|
||||||
|
pointerPosRef.current.y = e.clientY;
|
||||||
|
pointerPosRef.current.active = true;
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -344,7 +349,7 @@ void main() {
|
|||||||
uniforms.iTime.value = t * 0.001;
|
uniforms.iTime.value = t * 0.001;
|
||||||
|
|
||||||
// Update target based on pointer position and scroll offset
|
// Update target based on pointer position and scroll offset
|
||||||
if (pointerPosRef.current) {
|
if (pointerPosRef.current.active) {
|
||||||
const scale = (renderer as unknown as { dpr?: number }).dpr || 1;
|
const scale = (renderer as unknown as { dpr?: number }).dpr || 1;
|
||||||
let x, y;
|
let x, y;
|
||||||
|
|
||||||
@@ -361,7 +366,8 @@ void main() {
|
|||||||
x = (pointerPosRef.current.x - rect.left) * scale;
|
x = (pointerPosRef.current.x - rect.left) * scale;
|
||||||
y = (rect.height - (pointerPosRef.current.y - rect.top)) * scale;
|
y = (rect.height - (pointerPosRef.current.y - rect.top)) * scale;
|
||||||
}
|
}
|
||||||
mouseTargetRef.current = [x, y];
|
mouseTargetRef.current[0] = x;
|
||||||
|
mouseTargetRef.current[1] = y;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (mouseDampening > 0) {
|
if (mouseDampening > 0) {
|
||||||
@@ -376,8 +382,13 @@ void main() {
|
|||||||
cur[0] += (target[0] - cur[0]) * factor;
|
cur[0] += (target[0] - cur[0]) * factor;
|
||||||
cur[1] += (target[1] - cur[1]) * factor;
|
cur[1] += (target[1] - cur[1]) * factor;
|
||||||
} else {
|
} else {
|
||||||
if (pointerPosRef.current || isMobileRef.current) {
|
if (pointerPosRef.current.active || isMobileRef.current) {
|
||||||
uniforms.iMouse.value = mouseTargetRef.current;
|
// In no-dampening mode, update values directly.
|
||||||
|
// We copy values instead of assigning the reference to avoid aliasing issues
|
||||||
|
// (where cur and target become the same array) if dampening is enabled later
|
||||||
|
// without re-creating uniforms (though currently effect deps handle that).
|
||||||
|
uniforms.iMouse.value[0] = mouseTargetRef.current[0];
|
||||||
|
uniforms.iMouse.value[1] = mouseTargetRef.current[1];
|
||||||
}
|
}
|
||||||
lastTimeRef.current = t;
|
lastTimeRef.current = t;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -25,11 +25,6 @@ describe('Security Utils', () => {
|
|||||||
const expected = '<script>alert("XSS")</script>';
|
const expected = '<script>alert("XSS")</script>';
|
||||||
expect(sanitizeInput(input)).toBe(expected);
|
expect(sanitizeInput(input)).toBe(expected);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('escapes backticks', () => {
|
|
||||||
expect(sanitizeInput('`')).toBe('`');
|
|
||||||
expect(sanitizeInput('user`name')).toBe('user`name');
|
|
||||||
});
|
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('isValidEmail', () => {
|
describe('isValidEmail', () => {
|
||||||
|
|||||||
@@ -14,8 +14,7 @@ export function sanitizeInput(input: string): string {
|
|||||||
.replace(/</g, "<")
|
.replace(/</g, "<")
|
||||||
.replace(/>/g, ">")
|
.replace(/>/g, ">")
|
||||||
.replace(/"/g, """)
|
.replace(/"/g, """)
|
||||||
.replace(/'/g, "'")
|
.replace(/'/g, "'");
|
||||||
.replace(/`/g, "`");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Common disposable email providers and invalid domains
|
// Common disposable email providers and invalid domains
|
||||||
|
|||||||
Reference in New Issue
Block a user